merge: from main to 3.0 branch#34720
Merged
Merged
Conversation
…s under the VS2022 environment (#34689)
docs(pspace): taosx pspace docs #6653327869
* feat(taosdump): delete the contents related to RESTful * feat(taosdump): delete parameter parsing related to RESTful * feat(cli): delete the contents related to RESTful
Add installation instructions for 'screen' package.
test：add installation instructions for screen
Signed-off-by: WANG Xu <feici02@outlook.com>
docs: docker pull failure in FAQ
* feat: add SSH timeout options for remote commands * refactor: remove timeout from SSH and SCP commands for local execution * feat: add timeout handling for remote SSH commands
…34680) * fix: refactor file handling in TDCom class for improved readability * fix: enhance process cleanup in clean_taos_process to avoid terminating Jenkins agents * fix: remove redundant safe_rmtree function implementation * fix: add signal handling for graceful termination of subprocesses in run_win_cases * fix: declare exit_flag as global in process_pytest_file function * fix: refactor file handling in TDCom class for improved readability * fix: refactor file handling in TDCom class for improved readability * fix: improve code formatting and readability in TDCom class * fix: update exclusion list for Windows CI compatibility and improve cleanup process * test: add test_cases.task * feat: add Windows CI pipeline * fix: reduce wait time in process_pytest_file function * fix: update Windows pipeline for Python 3.8 support and improve path handling * test: delete test task * fix: enhance pytest command parsing with format validation and error logging
* Initial plan * Add weekly report GitHub Agentic Workflow Co-authored-by: feici02 <5568663+feici02@users.noreply.github.com> * chore: fix review comments and re-compile [skip ci] Signed-off-by: WANG Xu <feici02@outlook.com> --------- Signed-off-by: WANG Xu <feici02@outlook.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: feici02 <5568663+feici02@users.noreply.github.com> Co-authored-by: WANG Xu <feici02@outlook.com>
guanshengliang
requested review from
a team,
dapan1121,
feici02,
hzcheng and
zitsen
as code owners
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates a wide array of enhancements and fixes from the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Contributor
There was a problem hiding this comment.
Pull request overview
Merge from main into the 3.0 branch, bringing in cross-cutting updates across CI (notably Windows), privilege enforcement, stream/index stability fixes, build/linking changes (curl on Windows), and documentation refreshes.
Changes:
- Update Windows CI execution (new Jenkins pipeline file, revamped Windows case runner, refreshed Windows ignore list).
- Enhance privilege/permission behavior (lock/unlock role/user privileges, stricter column visibility checks, new/updated privilege tests).
- Improve runtime stability/behavior in core components (index filter guards, paged buffer cleanup/logging, stream trigger expression evaluation changes) and update build/docs accordingly.
Reviewed changes
Copilot reviewed 58 out of 70 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/taos-tools/src/taosdump.c | Removes unsupported -R/--restful CLI option handling. |
| test/new_test_framework/utils/common.py | Minor formatting/quoting tweaks in query-file execution helper. |
| test/ci/win_ignore_cases | Reworks Windows exclusion list (notably removes many prior exclusions). |
| test/ci/win.pipline | Adds/defines a Jenkins Windows pipeline script for build + test execution. |
| test/ci/run_win_cases.py | Refactors Windows pytest runner: signal handling, cleanup, timeouts, logging. |
| test/ci/run.sh | Adds timeout propagation for ssh/scp and improves artifact collection + local/remote execution handling. |
| test/ci/cases.task | Adds a TagIndices test, and fixes a benchmark entry format. |
| test/cases/25-Privileges/test_priv_rbac.py | Extends RBAC tests (column privileges + TMQ topic subscribe privilege coverage). |
| test/cases/25-Privileges/test_priv_control.py | Updates expected behavior for combined column/row privilege test. |
| test/cases/24-Users/test_user_privilege_sysinfo.py | Tightens sysinfo privilege expectations (more operations expected to error). |
| test/cases/15-TagIndices/test_index_tag_basic.py | Adds regression test ensuring tag-to-tag comparison doesn’t crash. |
| test/README.md | Documentation formatting and prerequisite updates (e.g., install screen). |
| source/util/src/tpagedbuf.c | Adds debug/stat logging, stronger cleanup/reset behavior, and file truncation on clear. |
| source/util/src/tcurl.c | Removes Windows no-op branch; always builds curl-backed notification connection handling. |
| source/libs/sync/src/syncMain.c | Improves log messages and warns on failed ping-timer stop. |
| source/libs/parser/src/parTranslater.c | Adjusts invisible column handling to return permission errors; refines privilege column checks; includes tags in row-priv column set. |
| source/libs/parser/src/parInsertSql.c | Clears per-statement privilege/tag-condition state to avoid reuse/leaks across calls. |
| source/libs/parser/src/parAuthenticator.c | Marks rewritten auth columns with appendByPrivCond flag. |
| source/libs/parser/inc/sql.y | Adds LOCK ROLE / UNLOCK ROLE privilege grammar. |
| source/libs/nodes/src/nodesUtilFuncs.c | Fixes column collection to hash cloned nodes; updates appendByPrivCond propagation logic. |
| source/libs/nodes/src/nodesCloneFuncs.c | Ensures SColumnNode.flags is copied during cloning. |
| source/libs/new-stream/src/streamUtil.c | Removes Windows-specific stub; stream notify code now always built. |
| source/libs/new-stream/src/streamTriggerTask.c | Refactors trigger expression evaluation and temp-column handling; changes capacity/clearing behavior. |
| source/libs/new-stream/src/dataSinkMgr.c | Fixes function terminator and replaces Chinese comments with English in touched spots. |
| source/libs/new-stream/src/dataSinkFile.c | Replaces Chinese comments with English in touched spots. |
| source/libs/new-stream/src/dataSinkCache.c | Replaces Chinese comments with English in touched spots. |
| source/libs/index/src/indexFilter.c | Adds guards/validation around operator params and skips index use for column-to-column comparisons. |
| source/libs/executor/src/groupcacheoperator.c | Adds error propagation/logging for downstream context reset and hash puts. |
| source/libs/catalog/src/ctgCache.c | Extends enqueue API to report ownership transfer; fixes user-auth enqueue ownership/cleanup semantics. |
| source/libs/catalog/src/catalog.c | Clarifies “shallow copy” caveat in catalogGetUserAuth doc comment. |
| source/dnode/vnode/src/vnd/vnodeSync.c | Improves vnode sync lifecycle log messages. |
| source/dnode/mnode/impl/src/mndDb.c | Populates additional DB info field (keepTimeOffset) in dump output. |
| source/dnode/mnode/impl/src/mndConsumer.c | Fixes missing mndReleaseUser call on exit path. |
| source/common/src/tpriv.c | Adds role lock/unlock privilege metadata and adjusts required roles for lock/unlock user. |
| source/common/CMakeLists.txt | Adds curl dependency linkage for Windows common target. |
| source/client/src/clientHb.c | Fixes cleanup by freeing full SUserAuthBatchRsp instead of only its array. |
| packaging/delete_ref_lock.py | Refactors git ref-lock cleanup into handler/factory structure with retries. |
| include/util/tpriv.h | Bumps PRIV_INFO_TABLE_VERSION for privilege table updates. |
| include/util/tcurl.h | Enables curl headers on Windows (static lib define) and removes prior Windows exclusion. |
| include/libs/nodes/querynodes.h | Adds appendByPrivCond bitfield to SColumnNode. |
| include/libs/new-stream/dataSink.h | Replaces large Chinese design block with shorter English notes; adds includes and comment cleanups. |
| docs/zh/27-train-faq/01-faq.md | Adds FAQ entry about Docker Hub pull failures and mitigation. |
| docs/zh/14-reference/05-connector/_windows_install.mdx | Updates referenced client package version to 3.4.0.9. |
| docs/zh/14-reference/05-connector/_macos_install.mdx | Updates referenced client package version to 3.4.0.9. |
| docs/zh/14-reference/05-connector/_linux_install.mdx | Updates referenced client package version and example tarball name. |
| docs/zh/14-reference/05-connector/30-python.mdx | Clarifies Python connector connect() description. |
| docs/zh/14-reference/02-tools/09-taosdump.md | Removes -R/--restful from taosdump docs. |
| docs/zh/14-reference/02-tools/07-taos-cli.md | Removes -R RESTful mention and trims trailing whitespace. |
| docs/zh/08-operation/03-install.md | Updates install doc versions to 3.4.0.9 and tarball names. |
| docs/zh/06-advanced/05-data-in/pic/pspace-06.png | Adds new pSpace screenshot asset (binary). |
| docs/zh/06-advanced/05-data-in/22-pspace.mdx | Adds Chinese pSpace Explorer “Data In” documentation page. |
| docs/zh/04-get-started/_03-docker.md | Adds link to Docker Hub failure FAQ in troubleshooting section. |
| docs/en/assets/pspace-06.png | Adds new pSpace screenshot asset (binary). |
| docs/en/assets/pspace-02.png | Adds new pSpace screenshot asset (binary). |
| docs/en/14-reference/05-connector/30-python.md | Clarifies Python connector connect() description (English). |
| docs/en/14-reference/02-tools/09-taosdump.md | Removes -R/--restful from taosdump docs (English). |
| docs/en/14-reference/02-tools/07-taos-cli.md | Removes -R RESTful mention and trims trailing whitespace (English). |
| docs/en/06-advanced/05-data-in/22-pspace.md | Adds English pSpace Explorer “Data In” documentation page. |
| cmake/external.cmake | Adds Windows ext_curl build/link settings and ensures build_externals depends on ext_curl across platforms. |
| .github/workflows/weekly-report.md | Adds/updates gh-aw weekly reporting workflow source. |
Comments suppressed due to low confidence (1)
cmake/external.cmake:930
- The
ExternalProject_Add(ext_curl ...)configuration usesURL_HASH MD5=...to verify the downloaded curl tarball. Weak algorithm MD5 is used for integrity verification of a third-party build dependency, which is vulnerable to collision attacks and no longer appropriate for supply-chain protection. Please switchURL_HASHto a stronger hash such as SHA-256 (or use an official signature mechanism) for allext_curlplatforms so that tampered archives cannot bypass integrity checks.
ExternalProject_Add(ext_curl
URL ${_url}
URL_HASH MD5=b25588a43556068be05e1624e0e74d41
PREFIX "${_base}"
CMAKE_ARGS -DCMAKE_BUILD_TYPE:STRING=${TD_CONFIG_NAME}
CMAKE_ARGS -DCMAKE_INSTALL_PREFIX:STRING=${_ins}
CMAKE_ARGS -DCMAKE_INSTALL_LIBDIR:PATH=lib
CMAKE_ARGS -DBUILD_SHARED_LIBS:BOOL=OFF
CMAKE_ARGS -DBUILD_TESTING:BOOL=OFF
CMAKE_ARGS -DBUILD_CURL_EXE:BOOL=OFF
CMAKE_ARGS -DENABLE_WEBSOCKETS:BOOL=ON
CMAKE_ARGS -DCURL_USE_SCHANNEL:BOOL=ON
CMAKE_ARGS -DCURL_USE_OPENSSL:BOOL=OFF
CMAKE_ARGS -DCURL_ZLIB:BOOL=OFF
CMAKE_ARGS -DCURL_DISABLE_LDAP:BOOL=ON
CMAKE_ARGS -DCURL_DISABLE_LDAPS:BOOL=ON
BUILD_COMMAND
COMMAND "${CMAKE_COMMAND}" --build . --config "${TD_CONFIG_NAME}"
INSTALL_COMMAND
COMMAND "${CMAKE_COMMAND}" --install . --config "${TD_CONFIG_NAME}" --prefix "${_ins}"
EXCLUDE_FROM_ALL TRUE
VERBATIM
)
else()
string(JOIN " " _c_flags ${_c_flags_list})
# URL https://github.com/curl/curl/releases/download/curl-8_2_1/curl-8.2.1.tar.gz
# URL_HASH MD5=b25588a43556068be05e1624e0e74d41
get_from_local_if_exists("https://github.com/curl/curl/releases/download/curl-8_2_1/curl-8.2.1.tar.gz")
ExternalProject_Add(ext_curl
URL ${_url}
URL_HASH MD5=b25588a43556068be05e1624e0e74d41
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+439
to
+442
| if (nParam == 2 && node->pRight != NULL && (nodeType(node->pRight)) != QUERY_NODE_VALUE) { | ||
| indexError("right node should be value, node:%p, type:%d", node->pRight, nodeType(node->pRight)); | ||
| SIF_ERR_RET(TSDB_CODE_QRY_INVALID_INPUT); | ||
| } |
There was a problem hiding this comment.
sifInitOperParams now hard-rejects any binary operator whose right operand is not a VALUE node. This conflicts with the later logic that tries to skip index usage for column-to-column comparisons (where right->condValue is NULL), and can turn valid predicates like tag1 = tag2 into TSDB_CODE_QRY_INVALID_INPUT instead of falling back to the non-index path. Consider marking the condition as SFLT_NOT_INDEX (or otherwise bypassing index filter) rather than returning an error when the right node is a column/expression.
Comment on lines
2969
to
+2973
| int32_t nrows = blockDataGetNumOfRows(pDataBlock); | ||
| code = colInfoDataEnsureCapacity(pResCol, nrows, false); | ||
| code = colInfoDataEnsureCapacity(pResCol, pDataBlock->info.capacity, false); | ||
| QUERY_CHECK_CODE(code, lino, _end); | ||
| TAOS_MEMSET(pResCol->nullbitmap, 0, BitmapLen(nrows)); | ||
| TAOS_MEMSET(pResCol->pData, 0, nrows); | ||
| TAOS_MEMSET(pResCol->nullbitmap, 0, BitmapLen(pDataBlock->info.capacity)); | ||
| TAOS_MEMSET(pResCol->pData, 0, pDataBlock->info.capacity); |
There was a problem hiding this comment.
In the pExpr == NULL || NODE_LIST branch, the code now sizes colInfoDataEnsureCapacity and memset using pDataBlock->info.capacity instead of the actual row count (blockDataGetNumOfRows). If capacity is much larger than nrows, this zero-fills and touches more memory than needed on every call. Consider using nrows for both ensure/clear operations (or only clearing the range [0, nrows)), to avoid a per-block performance regression.
Comment on lines
+162
to
+180
| # 定义清理函数（失败时抛出异常，终止测试） | ||
| def cleanup_environment(phase=""): | ||
| """清理进程和目录，失败则抛出异常终止测试""" | ||
| logger.info(f"Cleaning up environment ({phase})...") | ||
|
|
||
| # 1. 结束残留进程 | ||
| clean_taos_process() | ||
|
|
||
| # 2. 等待句柄释放 | ||
| time.sleep(1) | ||
|
|
||
| # 3. 删除 sim 目录，失败则终止 | ||
| if os.path.exists(work_dir): | ||
| try: | ||
| shutil.rmtree(work_dir) | ||
| logger.info(f"Removed {work_dir}") | ||
| except Exception as e: | ||
| logger.error(f"CRITICAL: Failed to remove {work_dir}: {e}") | ||
| raise RuntimeError(f"Cleanup failed: cannot remove work_dir") from e |
There was a problem hiding this comment.
cleanup_environment() deletes work_dir using plain shutil.rmtree(), but Windows often keeps file handles briefly after process termination (which you already note elsewhere) and you have a safe_rmtree() helper with retries. Using shutil.rmtree() here can make pre/post cleanup flaky and abort the entire suite. Consider switching this deletion to safe_rmtree(work_dir) (or an equivalent retry strategy).
Comment on lines
+93
to
+102
| def subscribe_topic(self, user, password, group_id, topic_name): | ||
| attr = { | ||
| 'group.id': group_id, | ||
| 'td.connect.user': user, | ||
| 'td.connect.pass': password, | ||
| 'auto.offset.reset': 'earliest' | ||
| } | ||
| consumer = Consumer(attr) | ||
| consumer.subscribe([topic_name]) | ||
|
|
There was a problem hiding this comment.
subscribe_topic() creates a TMQ Consumer and subscribes, but never closes it. This can leak sockets/threads and interfere with subsequent privilege tests in the same process. Please ensure the consumer is closed/unsubscribed (ideally in a try/finally) once the subscribe check is complete.
Comment on lines
+105
to
+123
| tdSql.connect("root", "taosdata") | ||
| tdSql.execute(f"create user u_topic pass '{self.test_pass}'") | ||
| tdSql.execute(f"create user u_consumer pass '{self.test_pass}'") | ||
| tdSql.execute(f"grant use on database d0 to u_topic") | ||
| tdSql.execute(f"grant create topic on database d0 to u_topic") | ||
| tdSql.execute(f"grant select on d0.stb0 to u_topic") | ||
| tdSql.connect("u_topic", self.test_pass) | ||
| time.sleep(5) # wait for privileges to take effect | ||
| tdSql.query("select * from d0.stb0") | ||
| tdSql.execute(f"create topic topic1 as select * from d0.stb0") | ||
| tdSql.error(f"create topic topic2 as select * from d0.stb1", expectErrInfo="Permission denied", fullMatched=False) | ||
| self.subscribe_topic("u_topic", self.test_pass, "g1", "topic1") | ||
| tdSql.connect("root", "taosdata") | ||
| tdSql.execute(f"grant use on database d0 to u_consumer") | ||
| tdSql.execute(f"grant subscribe on topic d0.topic1 to u_consumer") | ||
| tdSql.connect("u_consumer", self.test_pass) | ||
| time.sleep(5) # wait for privileges to take effect | ||
| self.subscribe_topic("u_consumer", self.test_pass, "g1", "topic1") | ||
|
|
There was a problem hiding this comment.
do_check_topic_privileges() relies on fixed time.sleep(5) delays for privilege propagation. This can make the test flaky on slow/loaded CI. Consider replacing the sleeps with a bounded retry loop that attempts the operation until it succeeds (or times out), so the test adapts to real propagation latency.
Comment on lines
1
to
+16
| # udf not supported in Windows CI | ||
| cases/uncatalog/system-test/0-others/test_udf_test.py | ||
| cases/uncatalog/system-test/0-others/test_udf_create.py | ||
| cases/uncatalog/system-test/0-others/test_udf_restart_taosd.py | ||
| cases/uncatalog/system-test/0-others/test_udf_cfg1.py | ||
| cases/uncatalog/system-test/0-others/test_udf_cfg2.py | ||
| cases/12-UDFs/test_udf_test.py | ||
| cases/12-UDFs/test_udf_create.py | ||
| cases/12-UDFs/test_udf_restart_taosd.py | ||
| cases/12-UDFs/test_udf_cfg1.py | ||
| cases/12-UDFs/test_udf_cfg2.py | ||
| cases/uncatalog/system-test/0-others/test_udfpy_main.py | ||
| cases/uncatalog/system-test/7-tmq/test_tmqUdf.py | ||
| cases/uncatalog/system-test/7-tmq/test_tmqUdf_multCtb_snapshot0.py | ||
| cases/uncatalog/system-test/7-tmq/test_tmqUdf_multCtb_snapshot1.py | ||
| # Stream not supported in Windows CI | ||
| cases/18-StreamProcessing/01-Snode/test_snode_mgmt_basic.py | ||
| cases/18-StreamProcessing/01-Snode/test_snode_mgmt_replica3.py | ||
| cases/18-StreamProcessing/01-Snode/test_snode_mgmt_replicas.py | ||
| cases/18-StreamProcessing/01-Snode/test_snode_params_alter_value.py | ||
| cases/18-StreamProcessing/01-Snode/test_snode_params_check_default.py | ||
| cases/18-StreamProcessing/01-Snode/test_snode_params_check_maxvalue.py | ||
| cases/18-StreamProcessing/01-Snode/test_snode_params_check_minvalue.py | ||
| cases/18-StreamProcessing/01-Snode/test_snode_privileges_recalc.py | ||
| cases/18-StreamProcessing/01-Snode/test_snode_privileges_stream.py | ||
| cases/18-StreamProcessing/01-Snode/test_snode_privileges_systable.py | ||
| cases/18-StreamProcessing/01-Snode/test_snode_privileges_twodb.py | ||
| cases/18-StreamProcessing/02-Stream/test_stream_check_name.py | ||
| cases/18-StreamProcessing/02-Stream/test_stream_long_name.py | ||
| cases/18-StreamProcessing/02-Stream/test_stream_no_snode.py | ||
| cases/18-StreamProcessing/02-Stream/test_stream_same_name.py | ||
| cases/18-StreamProcessing/03-TriggerMode/test_count_new.py | ||
| cases/18-StreamProcessing/03-TriggerMode/test_count.py | ||
| cases/18-StreamProcessing/03-TriggerMode/test_event_new.py | ||
| cases/18-StreamProcessing/03-TriggerMode/test_event.py | ||
| cases/18-StreamProcessing/03-TriggerMode/test_fill_history.py | ||
| cases/18-StreamProcessing/03-TriggerMode/test_period_1.py | ||
| cases/18-StreamProcessing/03-TriggerMode/test_sliding.py | ||
| cases/18-StreamProcessing/03-TriggerMode/test_state_new.py | ||
| cases/18-StreamProcessing/03-TriggerMode/test_state_disorder_update_new.py | ||
| cases/18-StreamProcessing/03-TriggerMode/test_state_window_close.py | ||
| cases/18-StreamProcessing/03-TriggerMode/test_state.py | ||
| cases/18-StreamProcessing/04-Options/test_abnormal_data_table.py | ||
| cases/18-StreamProcessing/04-Options/test_abnormal_data_vtable.py | ||
| cases/18-StreamProcessing/04-Options/test_meta_change_table.py | ||
| cases/18-StreamProcessing/04-Options/test_meta_change_vtable.py | ||
| cases/18-StreamProcessing/04-Options/test_options_abnormal.py | ||
| cases/18-StreamProcessing/04-Options/test_options_basic.py | ||
| cases/18-StreamProcessing/04-Options/test_options_ns.py | ||
| cases/18-StreamProcessing/04-Options/test_options_us.py | ||
| cases/18-StreamProcessing/04-Options/test_options_vtable.py | ||
| cases/18-StreamProcessing/05-Notify/test_notify.py | ||
| cases/18-StreamProcessing/06-ResultSaved/test_result_saved_comprehensive.py | ||
| cases/18-StreamProcessing/07-SubQuery/test_subquery_basic.py | ||
| cases/18-StreamProcessing/07-SubQuery/test_subquery_count_1.py | ||
| cases/18-StreamProcessing/07-SubQuery/test_subquery_count_2.py | ||
| cases/18-StreamProcessing/07-SubQuery/test_subquery_event.py | ||
| cases/18-StreamProcessing/07-SubQuery/test_subquery_sliding.py | ||
| cases/18-StreamProcessing/07-SubQuery/test_subquery_session.py | ||
| cases/18-StreamProcessing/07-SubQuery/test_subquery_state.py | ||
| cases/18-StreamProcessing/07-SubQuery/test_subquery_usage_restrict.py | ||
| cases/18-StreamProcessing/07-SubQuery/test_subquery_vtable_change.py | ||
| cases/18-StreamProcessing/08-Recalc/test_recalc_combined_options.py | ||
| cases/18-StreamProcessing/08-Recalc/test_recalc_delete_recalc.py | ||
| cases/18-StreamProcessing/08-Recalc/test_recalc_expired_time.py | ||
| cases/18-StreamProcessing/08-Recalc/test_recalc_ignore_disorder.py | ||
| cases/18-StreamProcessing/08-Recalc/test_recalc_manual_basic.py | ||
| cases/18-StreamProcessing/08-Recalc/test_recalc_manual_with_options.py | ||
| cases/18-StreamProcessing/08-Recalc/test_recalc_watermark.py | ||
| cases/18-StreamProcessing/20-UseCase/test_idmp_manager.py | ||
| cases/18-StreamProcessing/20-UseCase/test_idmp_meters.py | ||
| cases/18-StreamProcessing/20-UseCase/test_idmp_public.py | ||
| cases/18-StreamProcessing/20-UseCase/test_idmp_pv.py | ||
| cases/18-StreamProcessing/20-UseCase/test_idmp_tobacco.py | ||
| cases/18-StreamProcessing/20-UseCase/test_idmp_vehicle.py | ||
| cases/18-StreamProcessing/20-UseCase/test_idmp_yuxi.py | ||
| cases/18-StreamProcessing/20-UseCase/test_nevados.py | ||
| cases/18-StreamProcessing/20-UseCase/test_three_gorges_case4.py | ||
| cases/18-StreamProcessing/20-UseCase/test_three_gorges_case5.py | ||
| cases/18-StreamProcessing/20-UseCase/test_three_gorges_phase1.py | ||
| cases/18-StreamProcessing/20-UseCase/test_three_gorges_second_case1.py | ||
| cases/18-StreamProcessing/20-UseCase/test_three_gorges_second_case2.py | ||
| cases/18-StreamProcessing/20-UseCase/test_three_gorges_second_case3.py | ||
| cases/18-StreamProcessing/20-UseCase/test_three_gorges_second_case4.py | ||
| cases/18-StreamProcessing/20-UseCase/test_three_gorges_second_case6.py | ||
| cases/18-StreamProcessing/20-UseCase/test_three_gorges_second_case17.py | ||
| cases/18-StreamProcessing/20-UseCase/test_three_gorges_second_case18.py | ||
| cases/18-StreamProcessing/20-UseCase/test_three_gorges_second_case19.py | ||
| cases/18-StreamProcessing/20-UseCase/test_three_gorges_second_case19_bug1.py | ||
| cases/18-StreamProcessing/20-UseCase/test_three_gorges_second_case22.py | ||
| cases/18-StreamProcessing/20-UseCase/test_yuxi_TS_7152.py | ||
| cases/18-StreamProcessing/23-Compatibility/test_compatibility_cross_version.py | ||
| cases/18-StreamProcessing/30-OldPyCases/test_oldcase_at_once.py | ||
| cases/18-StreamProcessing/30-OldPyCases/test_oldcase_backquote_check.py | ||
| cases/18-StreamProcessing/30-OldPyCases/test_oldcase_checkpoint_info.py | ||
| cases/18-StreamProcessing/30-OldPyCases/test_oldcase_drop.py | ||
| cases/18-StreamProcessing/30-OldPyCases/test_oldcase_empty_identifier.py | ||
| cases/18-StreamProcessing/30-OldPyCases/test_oldcase_math_func.py | ||
| cases/18-StreamProcessing/30-OldPyCases/test_oldcase_snode_restart_with_checkpoint.py | ||
| cases/18-StreamProcessing/30-OldPyCases/test_oldcase_state_window.py | ||
| cases/18-StreamProcessing/30-OldPyCases/test_oldcase_stream_basic.py | ||
| cases/18-StreamProcessing/30-OldPyCases/test_oldcase_stream_multi_agg.py | ||
| cases/18-StreamProcessing/30-OldPyCases/test_oldcase_string_func.py | ||
| cases/18-StreamProcessing/30-OldPyCases/test_oldcase_taosdShell.py | ||
| cases/18-StreamProcessing/30-OldPyCases/test_oldcase_window_true_for.py | ||
| cases/18-StreamProcessing/31-OldTsimCases/test_oldcase_basic1.py | ||
| cases/18-StreamProcessing/31-OldTsimCases/test_oldcase_basic2.py | ||
| cases/18-StreamProcessing/31-OldTsimCases/test_oldcase_check.py | ||
| cases/18-StreamProcessing/31-OldTsimCases/test_oldcase_checkpoint.py | ||
| cases/18-StreamProcessing/31-OldTsimCases/test_oldcase_concat.py | ||
| cases/18-StreamProcessing/31-OldTsimCases/test_oldcase_continuewindowclose.py | ||
| cases/18-StreamProcessing/31-OldTsimCases/test_oldcase_state.py | ||
| cases/18-StreamProcessing/31-OldTsimCases/test_oldcase_twa.py | ||
| cases/18-StreamProcessing/23-Compatibility/test_compatibility_rolling_upgrade_all.py | ||
| cases/18-StreamProcessing/23-Compatibility/test_compatibility_backward_forward.py | ||
| cases/18-StreamProcessing/23-Compatibility/test_compatibility_rolling_upgrade.py | ||
| cases/uncatalog/system-test/7-tmq/test_tmq_td37436.py | ||
| # MQTT bnode not supported in Windows CI | ||
| cases/40-DataSubscription/03-MQTT/test_mqtt_smoking.py | ||
| cases/40-DataSubscription/03-MQTT/test_mqtt_bnodes.py | ||
| cases/40-DataSubscription/03-MQTT/test_mqtt_qos.py | ||
| cases/40-DataSubscription/03-MQTT/test_mqtt_special.py | ||
| cases/40-DataSubscription/03-MQTT/test_mqtt_rb.py | ||
| cases/17-DataSubscription/03-MQTT/test_mqtt_smoking.py | ||
| cases/17-DataSubscription/03-MQTT/test_mqtt_bnodes.py | ||
| cases/17-DataSubscription/03-MQTT/test_mqtt_qos.py | ||
| cases/17-DataSubscription/03-MQTT/test_mqtt_special.py | ||
| cases/17-DataSubscription/03-MQTT/test_mqtt_rb.py |
There was a problem hiding this comment.
win_ignore_cases no longer excludes the cases/18-StreamProcessing/... suite, but test/ci/cases.task still schedules a large number of StreamProcessing cases. This will make Windows CI attempt to run stream/snnode tests that are typically unsupported and likely fail. Please restore the StreamProcessing exclusions (or remove those cases from the Windows task list) so Windows CI only runs supported cases.
Comment on lines
165
to
+178
| if [ -z "${passwords[index]}" ]; then | ||
| echo "ssh -o StrictHostKeyChecking=no ${usernames[index]}@${hosts[index]}" | ||
| echo "timeout ${cmd_timeout} ssh -o StrictHostKeyChecking=no -o ServerAliveInterval=60 -o ServerAliveCountMax=3 ${usernames[index]}@${hosts[index]}" | ||
| else | ||
| echo "sshpass -p ${passwords[index]} ssh -o StrictHostKeyChecking=no ${usernames[index]}@${hosts[index]}" | ||
| echo "timeout ${cmd_timeout} sshpass -p ${passwords[index]} ssh -o StrictHostKeyChecking=no -o ServerAliveInterval=60 -o ServerAliveCountMax=3 ${usernames[index]}@${hosts[index]}" | ||
| fi | ||
| } | ||
|
|
||
| function get_remote_scp_command() { | ||
| local index=$1 | ||
| if [ -z "${passwords[index]}" ]; then | ||
| echo "scp -o StrictHostKeyChecking=no -r ${usernames[index]}@${hosts[index]}" | ||
| echo "scp -o StrictHostKeyChecking=no -r" | ||
| else | ||
| echo "sshpass -p ${passwords[index]} scp -o StrictHostKeyChecking=no -r" | ||
| fi |
There was a problem hiding this comment.
get_remote_ssh_command and get_remote_scp_command call ssh/scp with -o StrictHostKeyChecking=no and pass passwords via sshpass -p ${passwords[index]}. Disabling SSH host key verification makes it trivial for a man-in-the-middle on the network to impersonate a test host, and placing passwords on the command line exposes them via process listings or logs. Consider enforcing strict host key checking with a managed known_hosts file and switching to key-based authentication or alternative secret handling that does not embed plaintext passwords in command-line arguments.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request merges a significant number of changes from the main branch to the 3.0 branch. The changes span across build configuration, documentation, core source code, and testing infrastructure. Key improvements include adding support for building with curl on Windows, enhancing privilege management logic, fixing several resource leaks and correctness bugs, and substantially improving the robustness of the CI test scripts. The documentation has also been updated to reflect these changes. After a thorough review, the changes appear to be well-implemented and improve the overall quality and feature set of the codebase. I did not find any issues to report.
Note: Security Review is unavailable for this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue(s)
Checklist
Please check the items in the checklist if applicable.